Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 8.2 compatibility fixes #12

Merged
merged 2 commits into from
Oct 17, 2022
Merged

php 8.2 compatibility fixes #12

merged 2 commits into from
Oct 17, 2022

Conversation

falkenhawk
Copy link
Member

@falkenhawk falkenhawk commented Oct 15, 2022 •
edited
Loading

  • fix many deprecation notices, i.a. 'Creation of dynamic property is deprecated'
  • moved few properties around, adjusted wrong usages

@falkenhawk falkenhawk requested review from marcing, partikus and a team October 15, 2022 09:42
@falkenhawk falkenhawk changed the base branch from hotfix/php8.1 to master October 15, 2022 09:44
partikus
partikus approved these changes Oct 17, 2022
View reviewed changes
Copy link

@partikus partikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me 👍

@falkenhawk falkenhawk merged commit 2c44303 into master Oct 17, 2022
@falkenhawk falkenhawk deleted the fix/php8.2 branch October 17, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partikus partikus partikus approved these changes

@marcing marcing Awaiting requested review from marcing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falkenhawk @partikus