Upgrading image versions in rac-gcp-deploy #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensraaby
force-pushed
the
rac-gcp-deploy-bump
branch
from
a791173
to
869d63c
Compare
jensraaby
commented
Mar 5, 2024
| @@ -1,5 +1,5 @@ | |||
| ARG GCLOUD_SDK_VERSION | |||
| FROM google/cloud-sdk:${GCLOUD_SDK_VERSION:-328.0.0-alpine} | |||
| FROM google/cloud-sdk:${GCLOUD_SDK_VERSION:-466.0.0-alpine} | |||
There was a problem hiding this comment.
not sure what the base image is for this
jensraaby
commented
Mar 5, 2024
| @@ -15,13 +15,12 @@ aliases: | |||
| google-compute-zone: <<parameters.google-compute-zone>> | |||
|
|
|||
| orbs: | |||
| snyk: snyk/[email protected] | |||
| aws-ecr: circleci/[email protected] | |||
| snyk: snyk/[email protected] | |||
There was a problem hiding this comment.
TODO: check the changelog of this orb, can we go to v2?
jensraaby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!
Note that to build the docker image from the Dockerfile, it has to be published to dockerhub