Leverage std::make_unique & std::make_shared to create objects in the heap #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simpler code & more efficient because control block can be allocated with object.
|
airween
approved these changes
Oct 2, 2024
|
@eduar-hte - thanks again for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Replace naked
newcalls to create object instances in the heap that are then used to createstd::unique_ptr&std::shared_ptrinstances.why
Simplifies code and follows C++ Core Guidelines, see R.22: Use make_shared() to make shared_ptrs & R.23: Use make_unique() to make unique_ptrs
Additionally, the use of
std::make_sharedallows for an optimization by which the shared pointer's control block and the object can be allocated in the same memory block, which increasees memory locality (and thus performance).