Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path param to endpoint #394

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Add path param to endpoint #394

merged 3 commits into from
Sep 15, 2024

Conversation

ksg97031
Copy link
Member

Hello @hahwul,

When you have time, I would appreciate it if you could review this.
Have a great Chuseok!!

Resolve: #389

Output

Below is the output after the changes have been applied:
image

When Using the --set-pvalue=test Flag

Here is the output when the --set-pvalue=test flag is set:
image

Additional Suggestion:

Currently, the --set-pvalue flag is applied to the values of all parameters.
IMAO, It might be better to enhance this option to allow specifying the value for a particular parameter by its key.

@ksg97031 ksg97031 self-assigned this Sep 14, 2024
@hahwul hahwul added this to the v0.18.0 milestone Sep 15, 2024
@hahwul
Copy link
Member

hahwul commented Sep 15, 2024

@ksg97031
Wow, great work!!

@hahwul hahwul merged commit 6febc41 into dev Sep 15, 2024
1 check passed
@hahwul
Copy link
Member

hahwul commented Sep 15, 2024

@ksg97031 그리고 즐거운 추석 보내세요 :D

@ksg97031 ksg97031 deleted the feature/add-path-param-to-endpoint branch September 17, 2024 06:00
@hahwul hahwul mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants