Refactor status codes handing logic #408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksg97031
먼저 좋은 기능 만들어주셔서 감사합니다! #406
dev 브랜치에서 테스트해보는데
--status-codes
가 사용되지 않는 경우에도update_status_codes
가 호출되는 것 같습니다.코드를 살펴봤는데, exclude_codes가 Bool 타입으로 사용되는 것 같진 않은데 any_to_bool의 인자값으로 쓰이고 있어 이로 인해 해당 부분에서 false가 되고 "" 가 아니기에 무조건 돌아가지 않았을까 싶습니다. 의도된 로직일 수도 있어 일단 조심스럽게 수정 버전으로 PR 드려봅니다.
검토 부탁드려요 :D