Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main branch : not showing the quotes #125

Open
arademaker opened this issue Jul 26, 2019 · 3 comments
Open

main branch : not showing the quotes #125

arademaker opened this issue Jul 26, 2019 · 3 comments

Comments

@arademaker
Copy link
Member

simple and double quotes marking examples are not shown in the interface.
odanoburu added a commit that referenced this issue Jul 26, 2019
@odanoburu
* display quotes in sentence
6c6644c 
closes #125
@odanoburu odanoburu mentioned this issue Jul 26, 2019
Closed
@odanoburu
Copy link
Contributor

tbh this doesn't bother me since we wanted to get rid of the quotes anyway, plus that's not a problem in dev. but I've opened a PR if you'd like a fix.

@arademaker
Copy link
Member Author

I think it is important, for instance, imagine a quote suggesting a non-conventional interpretation of a word. But as always, only after seeing the results I will be able to judge the readability. I suggest adding it as an option show-quotes on/ff.

@odanoburu
Copy link
Contributor

you're right, the display of this synset is confusing: http://wnpt.sl.res.ibm.com/wn/synset?id=01156750-a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arademaker @odanoburu