Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 10.0.x to 10.0.3 all channels, 9.1.6 to 10.0.3 at stable #139

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Sep 14, 2017

  • 9.0.10 to 9.1.6 at stable channel
  • 9.1.6 to 10.0.3 at stable channel
  • 10.0.x to 10.0.3 for all channels except daily
    daily channel as usual allows 10.0.x to master

@VicDeo
Copy link
Member Author

VicDeo commented Sep 14, 2017

@PVince81 so, what about 9.0 to 9.1 at stable? Will we allow this too?
Thus two step migration from 9.0 to 10.0 will be possible. Currently we lock 9.0 users at stable on 9.0.10 and this PR doesn't change this behavior.

cc @hodyroff

@VicDeo VicDeo force-pushed the release-10.0.3 branch 4 times, most recently from 65a49a4 to c60978f Compare September 15, 2017 11:23
@PVince81
Copy link
Contributor

so, what about 9.0 to 9.1 at stable? Will we allow this too?

@VicDeo yeah, let's do that too to encourage upgrading to 10.0.3

@PVince81
Copy link
Contributor

@VicDeo @davitol can we test and deploy this ?

@davitol
Copy link
Contributor

davitol commented Sep 21, 2017

Related issue:
owncloud/updater#442

@davitol
Copy link
Contributor

davitol commented Sep 21, 2017

  • 9.0.10 to 9.1.6 at stable channel
  • 9.1.6 to 10.0.3 at stable channel
  • 10.0.1 to 10.0.3 for all channels except daily
    daily channel as usual allows 10.0.x to master

Tested and works.

Known issues:

Also we have to take into account that encryption gets disable after updating from 10.0.1 to 10.0.3 and admin has to reenable it

@PVince81
Copy link
Contributor

Also we have to take into account that encryption gets disable after updating from 10.0.1 to 10.0.3 and admin has to reenable it

@davitol is it really disabled ? On my instance (not updated with updater but with distro package), while the UI looked like encryption mode has not be selected, it still works with user-keys.

@davitol
Copy link
Contributor

davitol commented Sep 22, 2017

@davitol is it really disabled ? On my instance (not updated with updater but with distro package), while the UI looked like encryption mode has not be selected, it still works with user-keys.

@PVince81 Yes, after updating it appears disabled:

screen shot 2017-09-22 at 13 54 00

screen shot 2017-09-22 at 13 52 19

So if admin doesn't enable the module again, the file is not accesible for the user

screen shot 2017-09-22 at 13 53 18

@VicDeo
Copy link
Member Author

VicDeo commented Sep 22, 2017

@davitol
yes, like you reported before owncloud/updater#428 the fix is in 10.0.3
unfortunately it doesn't work backwards, only since 10.0.3 itself

@PVince81
Copy link
Contributor

If not fixable we need a good way to communicate this. Sadly we can't display messages in the updater like the release notes.

@davitol davitol self-requested a review September 25, 2017 07:29
@davitol
Copy link
Contributor

davitol commented Sep 25, 2017

👍 QA is finished so @VicDeo @PVince81 How to go on with the "buggy" scenarios above.

@VicDeo
Copy link
Member Author

VicDeo commented Sep 28, 2017

Scenarios are covered in https://central.owncloud.org/t/10-0-3-notes-on-using-built-in-web-updater/9702
Let's the battle begin 👘

@VicDeo VicDeo merged commit f8d8df1 into master Sep 28, 2017
@VicDeo VicDeo deleted the release-10.0.3 branch September 28, 2017 11:53
@VicDeo
Copy link
Member Author

VicDeo commented Sep 28, 2017

@crrodriguez this one please ;)

@crrodriguez
Copy link
Contributor

@VicDeo done

@PVince81
Copy link
Contributor

PVince81 commented Oct 9, 2017

@VicDeo can we add the encryption bit to the release notes too ? https://doc.owncloud.org/server/latest/admin_manual/release_notes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants