Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal #4117

Closed
11 tasks done
jesmrec opened this issue Aug 3, 2023 · 4 comments · Fixed by #4214
Closed
11 tasks done

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal #4117

jesmrec opened this issue Aug 3, 2023 · 4 comments · Fixed by #4214

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 3, 2023

After 4.0 with the new spaces feature, auto uploads were only done over the personal space.

Auto upload

Current:

  1. Enable auto uploads
  2. Select account to upload pictures -> dialog to select account
  3. Submit account

Expected:

  1. Enable auto uploads
  2. Select account to upload pictures -> dialog to select account
  3. If selected account is oCIS, show the list of spaces including Personal. Only the ones with writing permission
  4. Submit account and space and show the result in te view

Related: #4088

Changing the selected account should reset the value of the path: #4117 (comment)

Some questions to clarify:

  • What would happen if the write permission is revoked?
  • What would happen if the user lost access to the space or the space is disabled?

TASKS

  • Research (if needed)
  • Create branch feature/streamlined_log_file_upload_functionality
  • Development tasks
    • Implement Spaces functionality in auto upload
    • Migration database
    • Implement navigate to file list of this space
    • Implement changes in ui/ux
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master
@michaelstingl
Copy link
Contributor

What would happen if the write permission is revoked?

Same as oC10 when I auto-upload to a received Share, and the owner changes my permissions.

@michaelstingl michaelstingl added the p3-medium Normal priority label Aug 21, 2023
@jesmrec
Copy link
Collaborator Author

jesmrec commented Sep 25, 2023

Checking current behaviour:

  • If auto uploads folder is removed -> it's created again
  • if account is disabled in sever -> Connection error
  • if account is removed in server -> Credentials error
  • if account is removed in client -> Warning, camera uploads will get disabled.
  • If folder does not have permissions -> not selectable
  • If folder loses permissions -> Permission error

So, expanding those behaviours

  • If space does not have upload permissions -> not selectable
  • If space loses writing permission that was granted before -> Permission error
  • If space is disabled/removed -> Error to define

@jesmrec
Copy link
Collaborator Author

jesmrec commented Nov 7, 2023

Checking this... one suggestion:

If there are more than one account in device and in Auto Upload is switched the account, Picture Upload Path should be reset to default (/CameraUpload). What do you think??

@jesmrec
Copy link
Collaborator Author

jesmrec commented Nov 7, 2023

If there are more than one account in device and in Auto Upload is switched the account, Picture Upload Path should be reset to default (/CameraUpload). What do you think??

changing the selected account should reset the value of the path:

Change from oC10 account to oC10 account -> /CameraUpload
Change from oC10 account to oCIS account -> Personal: /CameraUpload
Change from oCIS account to oC10 account -> /CameraUpload
Change from oCIS account to oCIS account -> Personal: /CameraUpload

CC @Aitorbp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants