Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Don't redact auth type HTTP request logging #4249

Closed
10 tasks done
michaelstingl opened this issue Dec 8, 2023 · 1 comment · Fixed by #4257
Closed
10 tasks done

[FEATURE REQUEST] Don't redact auth type HTTP request logging #4249

michaelstingl opened this issue Dec 8, 2023 · 1 comment · Fixed by #4257
Assignees
Labels
Estimation - 3 (M) Feature request p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Dec 8, 2023

Describe the solution you'd like

I'd like to log the auth method, and redact only the actual credentials.

Additional context

Desktop example:

        "header":
        {
            "Authorization": "Bearer [redacted]",

iOS example:

Authorization: Bearer [redacted:1]

TASKS

  • Research (if needed)
  • Create branch feature/reveal_redacted_info_logs
  • Development tasks
    • Process the string to show just the authentication method
    • Create a brandable parameter to show or hide redacted info
    • Create a MDM parameter for the same
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/reveal_redacted_info_logs into master
@jesmrec
Copy link
Collaborator

jesmrec commented Dec 11, 2023

New requirement:

Add new option to reveal [redacted] info with debugging purposes. Options:

  • New branding/MDM option
  • Reveal always in debug mode (not sure if this is the best option)

more options, welcome.

@jesmrec jesmrec added Sprint p2-high Escalation, on top of current planning, release blocker Estimation - 3 (M) labels Dec 11, 2023
@JuancaG05 JuancaG05 self-assigned this Dec 12, 2023
@JuancaG05 JuancaG05 linked a pull request Dec 13, 2023 that will close this issue
1 task
@Aitorbp Aitorbp removed the Sprint label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation - 3 (M) Feature request p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants