-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Don't redact auth type HTTP request logging #4257
Conversation
When using the MDM parameter, if logs are already enabled, we need to disable and re-enable them again for this option to work properly. This is because we cannot perform an active listening to changes in MDM parameters, we just read them when necessary, and in this case, we decide if we show sensitive information or not (by reading the MDM parameter) every time we enable logs. |
Okay for me, that MDM config changes require a restart of the app. iOS app for example triggers a notification to tell the user to close and re-open the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I leave you some doubts here:
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/logging/LogInterceptor.kt
Show resolved
Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/logging/LogInterceptor.kt
Show resolved
Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/logging/LogInterceptor.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
QA checks
OK from my side |
… in HTTP requests
0aa1512
to
6d5584c
Compare
[FEATURE REQUEST] Don't redact auth type HTTP request logging
Related Issues
App: #4249
QA