Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technical] Gradle Version Catalog #4035

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

abelgardep
Copy link
Contributor

Migrates current dependencies declaration to Gradle Version Catalog. More info about it can be found here

Dependabot already supports this feature, so it should send PR to update the versions defined in the TOML file 🥇

I created 2 bundles to illustrate its use, but feel free to create as many as u consider 👍

espresso = ["androidx-test-espresso-contrib", "androidx-test-espresso-core", "androidx-test-espresso-intents", "androidx-test-espresso-web"]
markwon = ["markwon-core", "markwon-ext-tables", "markwon-ext-strikethrough", "markwon-ext-tasklist", "markwon-html"]

So we can add several dependencies that are related and are introduced all together like this:
implementation libs.bundles.espresso


QA

@jesmrec
Copy link
Collaborator

jesmrec commented May 9, 2023

Thanks a lot!! will check your contribution.

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @abelgardep! Take a look at the comments I added and, if possible, rebase it with the current status of master branch 😉

gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
@abelgardep
Copy link
Contributor Author

Ok, changes applied. You can check how dependabot updates the versions in the fork

Let me know if there is something else I could do @JuancaG05

And, of course, this is just the first iteration, we can update it in the way we consider. New bundles, other way to declare the versions, or whatever..

For example, we could consider introducing directly the version for one-time uses. Instead of:

[versions]
stetho = "1.6.0"

[libraries]
stetho = { group = "com.facebook.stetho", name = "stetho", version.ref = "stetho" }

Use it directly:

[libraries]
stetho = { group = "com.facebook.stetho", name = "stetho", version = "1.6.0" }

Feel free to customize it 👍

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @abelgardep! This will be very useful to keep ownCloud technically updated. BitRise will provide the final approve 😁
BTW I think this needs a rebase again since we merged several stuff in master, could you do it?

@JuancaG05
Copy link
Collaborator

Done! Thanks again @abelgardep! 🚀

@JuancaG05 JuancaG05 merged commit f64f991 into owncloud:master Jun 13, 2023
@JuancaG05 JuancaG05 removed the Sprint label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants