-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Technical] Gradle Version Catalog #4035
[Technical] Gradle Version Catalog #4035
Conversation
Thanks a lot!! will check your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @abelgardep! Take a look at the comments I added and, if possible, rebase it with the current status of master
branch 😉
95f83d6
to
89c3e71
Compare
Ok, changes applied. You can check how dependabot updates the versions in the fork Let me know if there is something else I could do @JuancaG05 And, of course, this is just the first iteration, we can update it in the way we consider. New bundles, other way to declare the versions, or whatever.. For example, we could consider introducing directly the version for one-time uses. Instead of:
Use it directly:
Feel free to customize it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @abelgardep! This will be very useful to keep ownCloud technically updated. BitRise will provide the final approve 😁
BTW I think this needs a rebase again since we merged several stuff in master, could you do it?
dec4f3f
to
56e6070
Compare
Done! Thanks again @abelgardep! 🚀 |
Migrates current dependencies declaration to Gradle Version Catalog. More info about it can be found here
Dependabot
already supports this feature, so it should send PR to update the versions defined in the TOML file 🥇I created 2 bundles to illustrate its use, but feel free to create as many as u consider 👍
So we can add several dependencies that are related and are introduced all together like this:
implementation libs.bundles.espresso
QA