-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Manual removal of local storage #4334
Conversation
c5ffe1a
to
ec30fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several things to check here yet @Aitorbp
...udApp/src/main/java/com/owncloud/android/presentation/accounts/AccountsManagementActivity.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/providers/LocalStorageProvider.kt
Outdated
Show resolved
Hide resolved
...java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSourceTest.kt
Outdated
Show resolved
Hide resolved
...java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSourceTest.kt
Show resolved
Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/files/FileRepository.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/test/java/com/owncloud/android/data/files/repository/OCFileRepositoryTest.kt
Outdated
Show resolved
Hide resolved
b05ec0d
to
3698f48
Compare
owncloudData/src/main/java/com/owncloud/android/data/files/db/FileDao.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/providers/LocalStorageProvider.kt
Outdated
Show resolved
Hide resolved
...java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSourceTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes and ready to go @Aitorbp
@Test | ||
fun `getDownloadedFilesForAccount returns an empty list when datasource returns an empty list`() { | ||
every { localFileDataSource.getDownloadedFilesForAccount(OC_ACCOUNT_NAME) } returns emptyList() | ||
|
||
val result = ocFileRepository.getDownloadedFilesForAccount(OC_ACCOUNT_NAME) | ||
|
||
assertEquals(emptyList<OCFile>(), result) | ||
|
||
verify(exactly = 1) { localFileDataSource.getDownloadedFilesForAccount(OC_ACCOUNT_NAME) } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, the result is what the datasource returns, we're not giving it a special treatment in-between
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Let's QA this one... |
QA checks:
|
(2) [WONT FIX]i don't want to look crazy, but the new icon looks like a brush more than a broom, not sure how clear it will be for users. This is how it looks like, any better idea @tbsbdr?: |
as suggested by you: lets stick to the icon you suggested for now and show a dialog to that the user gets reassured within the text dialog, what will happen if he/she proceeds. my perspective is, this icon is just a temporary solution because we don't have a better one as of now. For the future, I can also think about using a "drawer menu" like you suggested and already made for files. This could be a better way to add more actions because we can fit more in it. In a drawer, we can also put in some text to explain what the icons mean. Drawer example from material design |
So, the brush-broom icon will be the first approach. We'll work in future improvements |
Approved on my side |
bd88dcc
to
7650be0
Compare
…ilesForAccount function
…ity, listener in AccountsManagementAdapter and cleanAccount function with the use case
…ions/variables, refactor classes and changes xml
7650be0
to
762ab03
Compare
Related Issues
App: #4174
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA
checks performed: #4334 (comment)
Reports: