Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Lens icon in folder picker #4339

Merged
merged 10 commits into from
Mar 18, 2024
Merged

[FIX] Lens icon in folder picker #4339

merged 10 commits into from
Mar 18, 2024

Conversation

joragua
Copy link
Collaborator

@joragua joragua commented Mar 14, 2024 •
edited by jesmrec
Loading

Related Issues

App: #4311

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Checks done: #4339 (comment)

@joragua joragua linked an issue Mar 14, 2024 that may be closed by this pull request
[BUG] Lens icon in folder picker #4311
Closed
@joragua joragua force-pushed the fix/lens_icon_in_folder_picker branch from 47d7c45 to 3d876e9 Compare March 14, 2024 12:25
@joragua joragua requested a review from JuancaG05 March 15, 2024 08:48
@joragua joragua force-pushed the fix/lens_icon_in_folder_picker branch from b96ab24 to c6b702d Compare March 15, 2024 08:59
JuancaG05
JuancaG05 requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @joragua! Here I left some comments for you to review 😃

owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt Outdated Show resolved Hide resolved
@joragua joragua requested a review from JuancaG05 March 15, 2024 10:33
JuancaG05
JuancaG05 requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes suggested here @joragua! 😁

owncloudApp/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt Outdated Show resolved Hide resolved
@joragua joragua requested a review from JuancaG05 March 18, 2024 11:03
@joragua joragua force-pushed the fix/lens_icon_in_folder_picker branch from 977fc7d to 390728f Compare March 18, 2024 11:17
JuancaG05
JuancaG05 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @joragua! 😄

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 18, 2024 •
edited
Loading

Some QA checks related with the acceptance criteria

  • In a oCIS account, select any item and select Copy -> FIXED
  • Open a 3rd party app and share with oCIS account with spaces -> FIXED
  • Open Settings > Auto Uploads > Picture/Video uploads path -> FIXED

It's OK from my side

@joragua joragua merged commit fbc0a50 into master Mar 18, 2024
5 checks passed
@joragua joragua deleted the fix/lens_icon_in_folder_picker branch March 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees
No one assigned
Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Lens icon in folder picker
3 participants
@joragua @jesmrec @JuancaG05