-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files shared read-only are not marked read-only on the filesystem #3244
Comments
LOGS
|
This sounds like a regression. The wanted behaviour is: The file coming from a non editable share should be set to read only on the harddisk of the client. If that is changed manually to rw again (which is of course possible) the client should not even try to upload it, but report that the change can not be uploaded, restore the original file and move the local change to a conflict file. |
@dragotin I don't think we set non-editable shares to read-only on the local file system yet. Is this something that'd be ok to add to 1.8? I'll try to reproduce the problem with the rename-to-conflict-and-revert behavior. That one should definitely exist. |
I could reproduce the problem with the client trying to upload new data to a read-only share. |
In my reproduction with server 8.0.2, it's caused by a server issue: it reports the read-only share's permissions as |
Same response with server 8.0.3. |
/cc @DeepDiver1975: Server sends wrong permissions in above scenario. Needs investigation by server team. |
I've moved the server part to owncloud/core#16492. |
A discussion with @guruz @ogoffart @PVince81 has shown that changing local file permissions based on server permissions has several complications:
|
Same issue: |
Moved to 2.1 because the server dependencies will be in 8.2. |
If we have a true dependency on the server side, not sure this can be added for 2.1. |
(the server part is done in 8.2) |
I've tested this on 8.2 and it does indeed work, the etag changes on share-permission change and the client notices and updates the permissions stored in the database.
That means we can now watch the W permission of a file and adjust the local permissions to reflect that. |
maybe iff account()->serverVersionInt() >= 0x080200 Edit: actually, i think we should do it in any cases, since we would anyway try to even restore files that are modified if the database tells us that the files are read only |
@ogoffart Excellent point! |
Current status:
|
Setting shared-folder permissions:
We'll not go there for now. |
With Dektop v ownCloud-2.1.0.2871-nightly20151111.pkg I can see the same error |
@Dianafg76 You are running into the server problem owncloud/core#20426 of the permissions not being advertised correctly. Try sharing a directory instead. |
I believe that I have an opposite issue with version 2.1.0 build 5683. It is related or it is some other bug? |
Steps to reproduce
Expected behaviour
You can't Edit and Write the File aaa because you have unchecked the opcion Edit
Actual behaviour
When you Edit and Write the File aaa with the user2, Is not sync, it is appears an error
Server configuration
Version Desktop:
Version 1.8.2 (build 2369)
Web server:
{"installed":true,"maintenance":false,"version":"8.1.0.6","versionstring":"8.1 beta 2","edition":"Enterprise"}
The text was updated successfully, but these errors were encountered: