Refactor generic settings dialog #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move items on top like on Mac OS (right is free for accounts now) - The account icon no longer reflects the current status (in prep for multi-account)
|
|
|
@dragotin This is what I still had in stock |
|
/cc @jancborchardt |
| if( _accountSettings ) { | ||
| _accountSettings->setGeneralErrors(errors); | ||
| } | ||
| _accountSettings->setGeneralErrors(errors); | ||
| } |
There was a problem hiding this comment.
Please keep the if( _accountSettings ) { .... }
There was a problem hiding this comment.
why? I cannot be null as it gets initialized in the ctor. if you like we can make the pointer const to ensure nobody messes with it.
There was a problem hiding this comment.
Addressed now, please check if that's an acceptable solution. _protocolAction can't be trivially made const (not without adding more LOC than the check would take), so I'll use a check here.
|
I'd vote 👍 to merge into master |
danimo
added a commit
that referenced
this pull request
Dec 1, 2014
Refactor generic settings dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi-account)