Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split sharedialog code #3773

Merged
merged 10 commits into from
Oct 21, 2015
Merged

Split sharedialog code #3773

merged 10 commits into from
Oct 21, 2015

Commits on Oct 15, 2015

  1. Split sharing code 

    There is now a generic OCSJob which must be inherited by other jobs. This is in
prepartion for the other OCS job that will come (for the Sharee API endpoint
for example).

More logic is moved from the sharedialog to the OcsShareJob. So in the GUI code
we now only say what we want (a new share, set the password etc). And the code
in libsync will make that happen. Error handling is for now still done in the
GUI part.

For now the ocsjob and ocssharejob live in gui but probabaly we should
create a libshare or libocs at some point.
    @rullzer
    rullzer committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    b293aa7 View commit details
    Browse the repository at this point in the history

  2. Added setPublicUpload to OcsShareJob

    @rullzer
    rullzer committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    3ea944d View commit details
    Browse the repository at this point in the history

  3. OCSJob -> OcsJob and more docs

    @rullzer
    rullzer committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    db1f4d4 View commit details
    Browse the repository at this point in the history

  4. Now add parameters in a less crappy way

    @rullzer
    rullzer committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    a34b663 View commit details
    Browse the repository at this point in the history

  5. Thumbnailjob fixes 

    * Comments
* Use the path of the abstractnetworkjob
    @rullzer
    rullzer committed Oct 15, 2015
    1 Configuration menu
    Copy the full SHA
    4441053 View commit details
    Browse the repository at this point in the history

  6. Remove unused members

    @rullzer
    rullzer committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    0371933 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2015

  1. Move permissions to OcsShareJob

    @rullzer
    rullzer committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    f95fea9 View commit details
    Browse the repository at this point in the history

  2. Now only 1 constructor to ocssharejob 

    * Pass the share_id to the functions that need it
    @rullzer
    rullzer committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    40ab3ee View commit details
    Browse the repository at this point in the history

  3. Use overloaded functions

    @rullzer
    rullzer committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    0e97fbb View commit details
    Browse the repository at this point in the history

  4. Typos

    @rullzer
    rullzer committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    4a04dc1 View commit details
    Browse the repository at this point in the history