User group sharing #4055
User group sharing #4055
Conversation
| @@ -74,14 +74,34 @@ class OcsShareJob : public OcsJob { | |||
| void setPublicUpload(const QString &shareId, bool publicUpload); | |||
|
|
|||
| /** | |||
| * Set the permissions | |||
| * | |||
| * @pararm permissions | |||
|
Looks good! I added some comments.. So |
|
|
||
| void ShareeModel::shareesFetched(const QVariantMap &reply) | ||
| { | ||
| qDebug() << Q_FUNC_INFO << reply; |
For user/group/remote shares we were just missing the setPermissions functionality
Dialog can now retrive current shares for path, set the permissions on those shares and delete the share.
Mmmm, so it is done that way now. We could maybe merge them later. For now having separte stuff make developing and debugging so much easier. |
Now we have 1 simple dialog that includes 2 widgets. * ShareLinkWidget (for link shares) * ShareUserGroupWidget (for user/group shares) The ShareUserGroupWidget is only included if the server version is >= 8.2.0 For <8.2.0 the old behavior is preserved
You can't share with a user/group that you've already shared with You can't share with yourself
rullzer
force-pushed
the
user_group_sharing
branch
from
51d51f7
to
6431a2a
Compare
|
Ok it is getting more and more ready. Now we just have 1 share dialog. That uses both widgets. sharing seems to work for me pretty well now. TODO
I'll take a look at those issues this evening/tomorrow. Then we need some UI finetuning I think. But that is of later concern (and I'm not that good at it :P) |
|
Ok let me merge this now. We can have a look at the remaining issues later. But then testing can begin! |
For #3737
With the new sharing and OCS code in place this was a lot easier to write. Not really finished yet. But sharing with user/groups works!
There is still a lot of stuff that needs to be connected in the dialog.
The code needs comments. And more cleanup.
But overall it is looking promising :)
TODO:
For the last point I think it is best if someone with more estethic taste has a look once this is merged ;)
Now time for bed.
@MTRichards FYI
CC: @dragotin @ckamm @ogoffart @guruz