Keep fileId for deletedItems in a separate cache

owncloud · Apr 11, 2018 · d5c3b5e · d5c3b5e
1 parent 74e4712
commit d5c3b5e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/apps/dav/lib/DAV/FileCustomPropertiesBackend.php b/apps/dav/lib/DAV/FileCustomPropertiesBackend.php
@@ -71,16 +71,13 @@ public function delete($path) {
 			return;
 		}
 
-		$node = $this->getNodeForPath($path);
-		if (is_null($node)) {
-			return;
+		$fileId = $this->tree->getDeletedItemFileId($path);
+		if ($fileId !== false) {
+			$statement = $this->connection->prepare(self::DELETE_BY_ID_STMT);
+			$statement->execute([$fileId]);
+			$this->offsetUnset($fileId);
+			$statement->closeCursor();
 		}
-
-		$fileId = $node->getId();
-		$statement = $this->connection->prepare(self::DELETE_BY_ID_STMT);
-		$statement->execute([$fileId]);
-		$this->offsetUnset($fileId);
-		$statement->closeCursor();
 	}
 
 	/**

diff --git a/apps/dav/lib/Tree.php b/apps/dav/lib/Tree.php
@@ -31,6 +31,24 @@
  * having to walk through every node and trigger unnecessary extra queries.
  */
 class Tree extends \Sabre\DAV\Tree {
+
+	protected $deletedItems = [];
+
+	public function getDeletedItemFileId($path) {
+		if (isset($this->deletedItems[$path])) {
+			return $this->deletedItems[$path];
+		}
+		return false;
+	}
+
+	public function delete($path) {
+		$node = $this->getNodeForPath($path);
+		if (!is_null($node) && $node->getId()) {
+			$this->deletedItems[$path] = $node->getId();
+		}
+		parent::delete($path);
+	}
+
 	/**
 	 * Returns the INode object for the requested path
 	 *