Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File handling in admin: Also write to .user.ini #14748

Closed
ghost opened this issue Mar 9, 2015 · 1 comment · Fixed by #17182
Closed

File handling in admin: Also write to .user.ini #14748

ghost opened this issue Mar 9, 2015 · 1 comment · Fixed by #17182

Comments

@ghost
Copy link

ghost commented Mar 9, 2015

Hi,

it seems that the "file handling" input box in the admin backend to set a specific upload size is currently only writing to the .htaccess file: https://github.com/owncloud/core/blob/v8.0.0/lib/private/files.php#L217-L273

As newer OC versions are also shipping a .user.ini for other environments like fcgi the function probably could be extended to also write to this file.

@shoeper
Copy link

shoeper commented Mar 9, 2015

I'd also recommend to set 1MB larger value for max post size than for max upload size. When both have the same values uploading a file with the exact value will fail because the headers also need some bytes.

Furthermore a warning stating that it can take up to user_ini.cache_ttl seconds till the new value is taking effect, when user ini is used would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants