Update .user.ini when setting upload size limit

[RobinMcCorkell]

We try to change as many files as possible, so if we can write to .user.ini but not to .htaccess then we will (but the file contents will become inconsistent). Of course, whichever one actually affects the installation will be shown in the upload limit box in the admin settings, so there is no ambiguity in what happened, and the logs clearly state if any files could not be written to.

Not sure if this can be unit tested?

Fixes #14748

cc @PVince81 @LukasReschke @DeepDiver1975 @RealRancor @MorrisJobke

[mmattel]

👍

[karlitschek]

@DeepDiver1975 What do you think?

[MorrisJobke]

Maybe use file_get_contents: https://secure.php.net/manual/de/function.file-get-contents.php

[DeepDiver1975]

Not sure if this can be unit tested?

I guess it is possible

• by passing in the root folder where files are to be read/written this can be tweaked for unit testing.

[RobinMcCorkell]

@MorrisJobke I used fopen() and related functions so we only need to open the file and check for access once - before we do any reading or replacing of the contents. The original code used file_get_contents() and file_put_contents().

[scrutinizer-notifier]

A new inspection was created.

[RobinMcCorkell]

Unit tests! There was also a bug with checking the upper limit on the passed upload size. PHP does funny things with integer vs float comparisons, so our check didn't work. Now the check is much simpler, and ensures the value is sane.

Oh, there's also a new message in the admin panel that warns the admin that with PHP-FPM, the changes may take up to 5 minutes to take effect: http://php.net/manual/en/configuration.file.per-user.php#101705

[ghost]

🚀 Test PASSed.🚀

[RobinMcCorkell]

@DeepDiver1975 @MorrisJobke Re-review please?

[RobinMcCorkell]

@MorrisJobke Do you still think this should be using file_get_contents() and file_put_contents() instead of fopen()?

[MorrisJobke]

@MorrisJobke Do you still think this should be using file_get_contents() and file_put_contents() instead of fopen()?

I'm fine with the way it is now.

[RobinMcCorkell]

@DeepDiver1975 @MorrisJobke please review

[MorrisJobke]

Tested and works 👍 (also with changed permissions)