Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppFramework does not allow caching #18719

Closed
rullzer opened this issue Aug 31, 2015 · 2 comments
Closed

AppFramework does not allow caching #18719

rullzer opened this issue Aug 31, 2015 · 2 comments

Comments

@rullzer
Copy link
Contributor

rullzer commented Aug 31, 2015

The avatar controller sets the etag to the crc32 of the avatar.
However if I then use that etag with curl like:

curl -D - https://server/index.php/avatar/rullzer/32 --header 'If-None-Match: "4146254073"'

I do not get an 304.

I think this is caused by https://github.com/owncloud/core/blob/master/lib/private/appframework/http.php#L124. Since it compares the set ETag with the provided ETag. But the provided ETag has quotes.

@BernhardPosselt
Copy link
Contributor

Can't do this one, fix should be straight forward though. Can you take care of this?

@rullzer
Copy link
Contributor Author

rullzer commented Sep 1, 2015

Yep will do :)

@MorrisJobke MorrisJobke added this to the 8.2-current milestone Sep 1, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants