Properly return 304 in AppFramework #18730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ETag set in the IF_NONE_MODIFIED header is wraped in quotes (").
However the ETag that is set in response is not (yet). Also we need to
cast the ETag to a string.
* Added unit test
|
A new inspection was created. |
|
👍 tested, works |
|
Tested and works 👍 |
PVince81
pushed a commit
that referenced
this pull request
Sep 1, 2015
Properly return 304 in AppFramework
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #18719
Parse the IF_NONE_MATCH header properly so we actually return 304 responses.
To test:
curl -D - http://localhost/index.php/avatar/<USER>/32ETag: "abc")curl -D - http://localhost/index.php/avatar/<USER>/32 --header 'If-None-Match: "abc"'Before you would get a status 200 and the avatar returned again.
After you get a 304 Not Modified
CC: @Raydiation @LukasReschke @MorrisJobke @PVince81 @Xenopathic