progress of automated acceptance tests for locks

[individual-it]

As we discovered that litmus does not test enough of the WebDAV locking this issue tracks the progress of automated acceptance tests for locks

Lock symbol appears correctly in the webUI

0.5md to finish but IMO it would be over-engineering

things to check	user without email address	user with email address set	user with display-name set	lockscope	depth
user locks own file/folder	🤖	🤖	🤖	🤖
user locks own folder, lock propagates into subfolders	🤖				🤖
owner locks shared file/folder		🤖	🤖	🤖
share receiver locks file/folder		🤖	🤖	🤖
share receiver re-shares file/folder		🤖	🤖	🤖
public locks a file/folder	🤖	N/A	N/A
multiple locks are set by various users		🤖	🤖	N/A
unlocking by DAV removes the symbol	🤖
deleting the lock removes the symbol & lock of locked item	🤖			🤖
deleting the lock removes the symbol & lock of locked sub items	🤖			🤖

Locks can be deleted from the webUI

0.25md to finish

things to check	exclusive	shared
owner deletes lock that was set by herself	🤖	🤖
share receiver deletes lock that was by herself
owner deletes lock that was set by share receiver	🤖	🤖
owner deletes lock that was set by the public
share receiver deletes lock that was set by owner
delete lock from a sub-element

operation on locked files/folders

1.5md to finish

owner locked - owner tries the operation: ol-oo
owner locked - share receiver tries the operation: ol-ro
share receiver locked - owner tries the operation: rl-oo
share receiver locked - share receiver tries the operation: rl-ro
owner locked - public tries the operation: ol-po
public locked - owner tries the operation: pl-oo
public locked - public tries the operation: pl-po

operation	UI - ol-oo	UI - ol-ro	UI - rl-oo	UI - rl-ro	UI - ol-po	UI - pl-oo	UI - pl-po	DAV - ol-oo	DAV - ol-ro	DAV - rl-oo	DAV - rl-ro	DAV - ol-po	DAV - pl-oo	DAV - pl-po
download
upload in locked folder	🤖							🤖	🤖 #34327	🤖 #34327	🤖 #34327	🤖	🤖 #34327
upload overwrite in locked folder	🤖				🤖	🤖 #34327						🤖
upload overwrite locked file	🤖
rename	🤖				🤖
move_locked	🤖				🤖
move_in	🤖
move_in_overwrite	🤖
move_in_subdir
move_in_subdir_overwrite
move_out								🤖 #34370
move_out_subdir
copy_in
copy_in_overwrite
delete	🤖				🤖
mkdir								🤖
rmdir
share					N/A							N/A		N/A
unshare		🤖			N/A							N/A		N/A
unlock	🤖		🤖					🤖 #34303	🤖 #34303	🤖 #34303	🤖 #34303	🤖 #34303	🤖 #34303	🤖 #34303
lock exclusively locked											🤖
accept share	N/A				N/A	N/A	N/A	N/A				N/A	N/A	N/A
decline share	N/A	🤖			N/A	N/A	N/A	N/A				N/A	N/A	N/A
accept declined share	N/A	🤖			N/A	N/A	N/A	N/A				N/A	N/A	N/A
decline accepted share	N/A	🤖			N/A	N/A	N/A	N/A				N/A	N/A	N/A

more variations:

• with own token 🤖
• with token of an other user but own username/password 🤖
• reshared shares
• lockscope shared/exclusive
• locks set in levels above the public link
• depth 0/infinity

LOCKDISCOVERY

0.5md to finish

	lockroot	locktoken	timeout #33846	owner	count of locks
owner locked - owner tries discovery			🤖 #34320		🤖
owner locked - share receiver tries discovery			🤖 #34320
share receiver locked - owner tries discovery			🤖 #34320		🤖
share receiver locked - share receiver tries discovery					🤖
owner locked - public tries discovery	🤖	🤖	🤖 #34320
public locked - owner tries discovery			🤖 #34320
public locked - public tries discovery	🤖	🤖

more variations:

• lockscope shared/exclusive
• discovery of various levels
• locks on various levels
• set timeouts
• refresh lock

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #32782 (Add automated phpcs checks in drone for acceptance test code), #22485 (test), #22492 (test), #31579 (test), and #31718 (Improve webUI autocompletion acceptance tests).

[PVince81]

as discussed, @individual-it @davitol please decide what items make sense to cover.

I guess some items might cover multiple cases so we don't need to cover the whole matrix

[individual-it]

I'm suggesting to close this for now, we have a couple of issues raised and can improve test coverage as the issues are fixed and functionality expanded
@PVince81 @davitol feel free to reopen the ticket if you feel its needed