Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API acceptance tests to unlock files/folders #34303

Merged
merged 2 commits into from
Jan 30, 2019
Merged

API acceptance tests to unlock files/folders #34303

merged 2 commits into from
Jan 30, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jan 29, 2019 •
edited
Loading

Description

tests for the UNLOCK functionally

Related Issue

Motivation and Context

test if it works

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it self-assigned this Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #34303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34303   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25a1d7...e4279b3. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #34303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34303   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25a1d7...3b19cc7. Read the comment docs.

@individual-it individual-it mentioned this pull request Jan 30, 2019
Closed
phil-davis
phil-davis reviewed Jan 30, 2019
View reviewed changes
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated
| exclusive |

@issue-34302
Scenario Outline: as public unlock a shared folder locked by the file owner. To unlock use the owners locktoken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add similar "trying to" "is not possible" words

tests/acceptance/features/apiWebdavLocks/unlock.feature Outdated Show resolved Hide resolved
@individual-it
Copy link
Member Author

@phil-davis I've clarified the heading, please review again

@phil-davis
Copy link
Contributor

@individual-it merge and make a backport if you like.
The behavior for issue #34329 can be sorted out in a later PR.

@individual-it individual-it merged commit 68c4b20 into master Jan 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the unlockTests branch January 30, 2019 14:36
@individual-it individual-it mentioned this pull request Jan 30, 2019
Merged
@individual-it
Copy link
Member Author

backport in #34331

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@davitol davitol Awaiting requested review from davitol

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@individual-it individual-it

Labels
4 - To release dev:acceptance-tests feature:persistent-locking QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API acceptance tests to UNLOCK locked files
2 participants
@individual-it @phil-davis