Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload in browser #4767

Closed
1 of 4 tasks
butonic opened this issue Sep 8, 2013 · 8 comments
Closed
1 of 4 tasks

File upload in browser #4767

butonic opened this issue Sep 8, 2013 · 8 comments

Comments

@butonic
Copy link
Member

butonic commented Sep 8, 2013

With #4766 we will add proper conflict handling back to OC. But that is only a fallback mechanism that triggers when a conflict arises.

We can do better:

  • If uploading to the filelist check for conflicts before uploading. On conflict show a simple dialog like win8 showing only the number of conflicting files and allowing the user to choose a general resolution: skip all conflicts, overwrite all files, choose which files to keep (and show the conflicts dialog) or cancel upload.
  • When file versioning is enabled never show any dialog and always overwrite the file on the server. If the user made a mistake he can always get back the old version from the file history. (This is how dropbox does it)
  • Use xdg_user_dirs standard to upload files to meaningful default directories from an upload button in Apps like Pictures and Music:
  • Render progress bar in file list row, tracked in Files: location of upload progress bar #991
@butonic
Copy link
Member Author

butonic commented Sep 8, 2013

@jancborchardt comments on file upload?

@jancborchardt
Copy link
Member

@butonic is this point already implemented:

When file versioning is enabled never show any dialog and always overwrite the file on the server. If the user made a mistake he can always get back the old version from the file history. (This is how dropbox does it)

@butonic
Copy link
Member Author

butonic commented Nov 29, 2013

nope, not yet. none of the points are

@DeepDiver1975
Copy link
Member

@butonic status? THX

@butonic
Copy link
Member Author

butonic commented Feb 7, 2014

@DeepDiver1975 just a design forward. Nothing implemented. I don't think anybody is currently working on this.

@PVince81
Copy link
Contributor

Looks like at least the first checkbox is implemented ? 😄

@butonic
Copy link
Member Author

butonic commented Jun 21, 2014

@PVince81 nope, the current impementation is the fallback that is triggered when changes on the serverside have not yet made it to the browser UI (eg, upload via webdav). The first checkbox needs to be implemented here: https://github.com/owncloud/core/blob/master/apps/files/js/file-upload.js#L178 also see the video https://www.youtube.com/watch?v=4zbY6vr4DK4 that shows an initial conflict options dialog and afterwards the conflict dialog we currently have.

@jancborchardt jancborchardt modified the milestones: ownCloud 8, ownCloud 7 Jul 2, 2014
@jancborchardt jancborchardt changed the title Design forward: file upload in browser File upload in browser Jul 10, 2014
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-next, ownCloud 8 Jan 9, 2015
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.2-next, 8.1-current Mar 2, 2015
@jancborchardt jancborchardt modified the milestones: 9.0-next, 8.2-current Sep 15, 2015
@PVince81
Copy link
Contributor

The first checkbox was implemented in 8.2.2, see #19417

Moving the rest to 9.1

@PVince81 PVince81 modified the milestones: 9.1-next, 9.0-current Feb 12, 2016
@DeepDiver1975 DeepDiver1975 modified the milestones: backlog, 9.1-current Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants