-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files: location of upload progress bar #991
Comments
Seems like @wookinger has been working on this! He showed me an awesome prototype which already works quite well even with multiple files. Some things needing to be done, here for the record:
Awesome! |
And an update: @butonic has found a great hack for this, using a hard CSS gradient on the table row. This makes it look like a progress bar, and can also be used as a music player scrubber. |
I toyed around more with this. using the table as the progress bar and overshadowing it with opaque rows only seems to work in chrome. I'll try finding a different solution. Problem is that simply using the table row background as an indicator does not work in chrome ... I'm on it. |
Discussing this with my other half she suggested moving the progress bar for individual files to the 'Modified' column. That would be a lot easier to implement and give more detailed feedback than the current UI. @jancborchardt what do you think? |
@butonic yeah, that’s fine also, or a good step. Maybe a progress bar as wide as the whole row is not that visible anyway. Good call! |
With the file conflicts dialog I removed the placeholder row. @jancborchardt Before reintroducing it I'd like your feedback on the following approach: Iinstead of adding a row that contains the colums as present in the other rows I'd like to add a row spanning all columns. That will not only allow us to add a progress bar over the whole table, but also visually distinguish it from already existing files. It also makes it easier to not show file actions like 'rename', 'share' and 'history' until the upload is complete, saving us the effort to take care of a lot of corner cases. Also postponig to OC7 |
@butonic sorry for the late reply – I like the approach you described in your last comment! :) cc @owncloud/designers |
Closing in favor of #18589 (potentially moving the upload function into the sidebar) |
Currently, the upload progress bar is on the top right of the Files app. This is suboptimal because upload button, file and progress bar are as far apart as possible.
Rather, the progress bar should be the row of each file itself. That is, while uploading that specific file, its tr should become a progress bar, reflecting the state of upload. This works for single and multiple upload.
The text was updated successfully, but these errors were encountered: