Do only follow HTTP and HTTPS redirects #11248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want to follow redirects to other protocols since they might allow an adversary to bypass network restrictions. (i.e. a redirect to ftp:// might be used to access files of a FTP server which might be in a secure zone and not be reachable from the net but from the ownCloud server) Get final redirect manually using get_headers() Migrate to HTTPHelper class and add unit tests Conflicts: apps/files/ajax/newfile.php lib/private/files/storage/dav.php lib/private/server.php lib/private/util.php lib/public/iservercontainer.php
|
💣 Test FAILed. 💣 |
|
@owncloud-bot Retest this please. |
|
🚀 Test PASSed. 🚀 |
|
looks good. But not tested 👍 |
|
Removing gold since it's only a backport of a goldy. Assigning backport request label. Another reviewer please. @th3fallen |
|
See #11249 for stable5 |
|
💣 Test FAILed. 💣 |
|
@owncloud-bot Retest this please. |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 6 lines...] > git --version # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/heads/:refs/remotes/origin/ > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11248/merge^{commit} # timeout=10Checking out Revision f11e8c0d48d5809f9f5dd1f4d8eb8d60afc3b2ea (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f f11e8c0d48d5809f9f5dd1f4d8eb8d60afc3b2ea > git rev-list f4a2d6ac6d5a3f1d31f3a31562fa00440367d160 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng » sqlite,vm-slave-02Configuration pull-request-analyser-ng » sqlite,vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02Touchstone configurations resulted in FAILURE, so aborting...Started calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 4 second:bomb: Test FAILed. :bomb: |
|
@DeepDiver1975 FYI: |
|
@owncloud-bot Retest this please. |
1 similar comment
|
@owncloud-bot Retest this please. |
|
@icewind1991 @PVince81 Please test and review. |
|
💣 Test FAILed. 💣 Build result: FAILUREGitHub pull request #11248 of commit b2798af automatically merged.Building remotely on vm-slave-02 (SLAVE) in workspace /var/jenkins/workspace/pull-request-analyser-ng-simple@22 > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11248/merge^{commit} # timeout=10Checking out Revision 50c56d39ed2a638d2a0cfc506f220c8a551897df (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 50c56d39ed2a638d2a0cfc506f220c8a551897df > git rev-list 223ff8dbfd72c612664d0b7fe86a7fb0c66cc1a8 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 13 second💣 Test FAILed. 💣 |
|
@owncloud-bot Retest this please. |
|
💣 Test FAILed. 💣 Build result: FAILUREGitHub pull request #11248 of commit b2798af automatically merged.Building remotely on vm-slave-02 (SLAVE) in workspace /var/jenkins/workspace/pull-request-analyser-ng-simple > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11248/merge^{commit} # timeout=10Checking out Revision 84ecaaec5d067896f1e088b6233aec83228d9357 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 84ecaaec5d067896f1e088b6233aec83228d9357 > git rev-list 49ee52d21e7fae07d33530fb340d55eaad194c4e # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
@DeepDiver1975 Still failing... |
|
👍 |
LukasReschke
added a commit
that referenced
this pull request
Oct 16, 2014
Do only follow HTTP and HTTPS redirects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11032 to stable6