Adding repair step to fix missing etags - fixes #12172 #13278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +80,8 @@ public static function getRepairSteps() { | |||
| new RepairMimeTypes(), | |||
| new RepairLegacyStorages(\OC::$server->getConfig(), \OC_DB::getConnection()), | |||
| new RepairConfig(), | |||
| new AssetCache() | |||
| new AssetCache(), | |||
| new FillETags(\OC_DB::getConnection()) | |||
There was a problem hiding this comment.
add trailing , so the next repair step does not requrie changing two lines again?
|
Refer to this link for build results (access rights to CI server needed): |
|
Looks good 👍 |
| class FillETags extends BasicEmitter implements \OC\RepairStep { | ||
|
|
||
| /** @var \OCP\IConfig */ | ||
| protected $config; |
|
refs #12502 |
DeepDiver1975
force-pushed
the
repair-step-missing-etags
branch
from
f4b802b
to
7966eee
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
The inspection completed: 8 new issues, 4 updated code elements |
|
Works as intended. I deleted some etags and run the repair step 👍 |
MorrisJobke
added a commit
that referenced
this pull request
Jan 13, 2015
Adding repair step to fix missing etags - fixes #12172
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12172
@dragotin @PVince81 @icewind1991
From the pure sync algorithm pov it is sufficient to fill the etag with any random string which is not empty.