Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new OCS sharee API endpoint in the share dropdown #18236

Closed
wants to merge 1 commit into from
Closed

Use the new OCS sharee API endpoint in the share dropdown #18236

wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Contributor

@DeepDiver1975 @rullzer @blizzz

@nickvergessen nickvergessen added this to the 8.2-current milestone Aug 12, 2015
@nickvergessen nickvergessen force-pushed the ocs_api_for_sharees_in_dropdown branch from 5aa7053 to 0b5f138 Compare August 12, 2015 13:29
@nickvergessen nickvergessen mentioned this pull request Aug 17, 2015
Merged
6 tasks
@nickvergessen nickvergessen force-pushed the ocs_api_for_sharees_in_dropdown branch from 0b5f138 to c48a346 Compare August 17, 2015 13:33
@scrutinizer-notifier
Copy link

A new inspection was created.

nickvergessen
nickvergessen reviewed Aug 17, 2015
View reviewed changes
core/js/share.js
search: search.term.trim(),
limit: 200,
// FIXME need to get the share ids
// existingShares: OC.Share.itemShares,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81 @blizzz is the list of the share IDs anywhere available in JS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. You probably need the ones from the current file ? You might be able to extract it from the share dialog somehow... (good luck)

@nickvergessen nickvergessen modified the milestones: 9.0-next, 8.2-current Sep 15, 2015
@nickvergessen
Call OCS endpoint from share dropdown
0711335 
TODO: we need a list of the share ids
nickvergessen
nickvergessen reviewed Sep 15, 2015
View reviewed changes
core/js/share.js
format: 'json',
fetch: 'getShareWith',
search: search.term.trim(),
limit: 200,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perPage

@rullzer rullzer modified the milestones: 9.0-next, 8.2-current Sep 15, 2015
@MorrisJobke MorrisJobke mentioned this pull request Sep 24, 2015
Merged
@rullzer rullzer mentioned this pull request Dec 23, 2015
Merged
5 tasks
@rullzer
Copy link
Contributor

rullzer commented Dec 23, 2015

Replaced by #21349 using the backbone stuff.

@rullzer rullzer closed this Dec 23, 2015
@rullzer rullzer deleted the ocs_api_for_sharees_in_dropdown branch December 23, 2015 10:59
@mmattel mmattel restored the ocs_api_for_sharees_in_dropdown branch January 5, 2016 15:21
@mmattel mmattel deleted the ocs_api_for_sharees_in_dropdown branch January 5, 2016 15:46
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
1 - To develop dev:ocs feature:sharing
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @scrutinizer-notifier @rullzer @PVince81