Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the settings in the user management page #19354

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Conversation

rullzer
Copy link
Contributor

@rullzer rullzer commented Sep 25, 2015

Fixes #12727

Quick fix to save the state of the settings checkboxes. This makes sure that once they are set ownCloud remebers the settings.

Note that it currently is global. So all admins see the same. But like I said quick fix.

CC: @jancborchardt @PVince81 @MorrisJobke @LukasReschke

@MorrisJobke
Copy link
Contributor

Tested and works. 👍

I guess for 8.2 we are fine to fix this in the global way.

@MorrisJobke
Copy link
Contributor

@tessus You created the initial ticket ;) Do you mind to test this?

@kawohl You also reported this. ;)

@PVince81
Copy link
Contributor

@rullzer I guess you didn't find any existing JS API to save to "oc_preferences" instead of "oc_appconfig" ?

@PVince81
Copy link
Contributor

...JS API or backend endpoints

@rullzer
Copy link
Contributor Author

rullzer commented Sep 25, 2015

@PVince81 ah that could also be done of course... let me check.

@rullzer
Copy link
Contributor Author

rullzer commented Sep 25, 2015

@PVince81
Copy link
Contributor

Right, then 👍

@rullzer
Copy link
Contributor Author

rullzer commented Sep 25, 2015

@PVince81 I'll create proper tickets for 9.0. For now I think this solution is sufficient but then we should introduce OC.Preference to the js stuff and use that for 9.0. Since adding that now does not seem like a good idea.

@rullzer
Copy link
Contributor Author

rullzer commented Sep 25, 2015

Ticket in #19361

Store the setting in the user managerment page (e.g. show e-mail
address).

Fixes #12727
DeepDiver1975 added a commit that referenced this pull request Sep 25, 2015
Save the settings in the user management page
@DeepDiver1975 DeepDiver1975 merged commit f56c828 into master Sep 25, 2015
@DeepDiver1975 DeepDiver1975 deleted the fix_12727 branch September 25, 2015 12:05
@tessus
Copy link

tessus commented Sep 25, 2015

@MorrisJobke I'm running version 8.1.3, but I copied the 3 changed files from branch fix_12727 on top, but it didn't work. I expect that there are more dependencies than just these 3 files which are present only in the current master.

Thus the test failed for me. I could install oc from current master on a spare machine, but I guess several people have already done this.

@MorrisJobke
Copy link
Contributor

Thus the test failed for me. I could install oc from current master on a spare machine, but I guess several people have already done this.

Yes. Thanks anyway :)

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user page does not remember the selected check boxes
6 participants