Add visual cue when moving draggable item over droppable item,

[pellaeon]

ie. breadcrumb and filenameTd

The style on breadcrumb might need tweaking.

Solves #10369

[karlitschek]

very nice. thanks for the pull request :-)
@PVince81 @jancborchardt what do you think?

[MorrisJobke]

@pellaeon I can't find any visual changes, when testing with chrome. Can you maybe add some screenshots? Maybe I just tried the wrong stuff ;)

[pellaeon]

@MorrisJobke
Drag an item over a folder

Drag an item over breadcrumb

[PVince81]

@owncloud/designers

[PVince81]

@jancborchardt do you like this highlight ?

[jancborchardt]

The color of the highlight should be the same that is used for when an upload is successfully finished. And that shade of yellow should be defined centrally so we can pull it as highlightcolor and change it in one place.

[pellaeon]

It is the same color, copied from https://github.com/owncloud/core/blob/master/apps/files/css/upload.css#L171 .

I don't know how to define it centrally.

[PVince81]

• the hover should cover the whole row, now only the files row ? @jancborchardt

Tested, functionally it works.

[jancborchardt]

Yeah, the style should cover the whole row. We can adjust the exact color later.

[PVince81]

@pellaeon can you change it to cover the whole row ?

[pellaeon]

@PVince81 it now covers the whole row, also making the whole row droppable.

[PVince81]

Looks good to me, JS unit tests pass locally 👍

Merge ? @MorrisJobke @jancborchardt @rullzer @nickvergessen

[MorrisJobke]

This has conflicts :(

Generally I like this, but maybe we want to use a not that aggressive color. But that could be addressed in an additional PR. cc @owncloud/designers

@pellaeon Could you rebase and resolve the conflicts? Then we could merge this :)

[skjnldsv]

I wanted to propose some kind of striped background, but the css is goind wild.
I applied it to the tr, and all the td are disrupting the background, I never saw that! :/

[pellaeon]

@MorrisJobke rebased!

[skjnldsv]

Ok, apparently, my stripped background problem is a webkit issue. It work fine on other browsers.
Should we goo for it? I like it. :)

[PVince81]

@skjnldsv I'd rather vote against it, at least for now. Maybe reconsider striping all the things for 9.2 ?

Goal is to get this PR here merged soon.

[skjnldsv]

@PVince81 Yep, let's merge! :)

[PVince81]

@skjnldsv counting your comment as a 👍

[PVince81]

JS unit tests still passed locally, merging

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.