Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable8.1] Use "json_encode" and "json_decode" instead of unserialize #22632

Merged
merged 2 commits into from
Feb 25, 2016

Conversation

MorrisJobke
Copy link
Contributor

Backport of #18762 and #21999

  • approval by @karlitschek needed
  • fixes issue that was noticed in owncloud/enterprise#1094

cc @LukasReschke @blizzz @owncloud/ldap Please review

@MorrisJobke MorrisJobke added this to the 8.1.6-current-maintenance milestone Feb 24, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @blizzz, @LukasReschke and @Xenopathic to be potential reviewers

@karlitschek
Copy link
Contributor

please backport 👍

@LukasReschke
Copy link
Member

👍

@blizzz
Copy link
Contributor

blizzz commented Feb 24, 2016

👍 works. However, when the cache contained other data before, this leads to a blank page. The cache gets cleared on update (tested with manually increasing LDAP app version). So, it's not an issue

MorrisJobke added a commit that referenced this pull request Feb 25, 2016
[stable8.1] Use "json_encode" and "json_decode" instead of unserialize
@MorrisJobke MorrisJobke merged commit aebafad into stable8.1 Feb 25, 2016
@MorrisJobke MorrisJobke deleted the stable8.1-backport-18762 branch February 25, 2016 14:30
@lock
Copy link

lock bot commented Aug 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants