move federated sharing settings to the federatedfilesharing app #24073
Conversation
|
By analyzing the blame information on this pull request, we identified @jancborchardt, @LukasReschke and @DeepDiver1975 to be potential reviewers |
schiessle
force-pushed
the
move_federated_sharing_settings_to_app
branch
from
be99358
to
d0e92ef
Compare
schiessle
force-pushed
the
move_federated_sharing_settings_to_app
branch
from
d0e92ef
to
e101054
Compare
|
👍 |
|
second reviewer... maybe @nickvergessen or @ChristophWurst ? Thanks! |
| @@ -55,7 +55,9 @@ | |||
|
|
|||
| $server = $serverFactory->createServer($baseuri, $requestUri, $authBackend, function (\Sabre\DAV\Server $server) use ($authBackend, $linkCheckPlugin) { | |||
| $isAjax = (isset($_SERVER['HTTP_X_REQUESTED_WITH']) && $_SERVER['HTTP_X_REQUESTED_WITH'] === 'XMLHttpRequest'); | |||
| if (OCA\Files_Sharing\Helper::isOutgoingServer2serverShareEnabled() === false && !$isAjax) { | |||
| $federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application('federatedfilesharing'); | |||
There was a problem hiding this comment.
throws an exception when the app is not enabled, because autoloading from the path is not allowed...
There was a problem hiding this comment.
I know, but at the moment the app is always enabled. I also want to move the settings 1:1 with as few changes as possible. Maybe in a second step the shareManager should have a "getShareProvider($shareType)" method which we could query instead of the share provider directly. cc @rullzer
There was a problem hiding this comment.
mmmm lets think about that... because in general I think the abstraction of the share manager is pretty nice.. But I see the use case
|
But okay, lets do that in a second step |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
move federated sharing settings to the "federated files sharing"-app, part of #22209
cc @rullzer