Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate appinfo/update.php - RepairSteps within info.xml are to be … #24177

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Deprecate appinfo/update.php - RepairSteps within info.xml are to be … #24177

merged 1 commit into from
Apr 22, 2016

Conversation

DeepDiver1975
Copy link
Member

…used

@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Apr 22, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @MorrisJobke, @nickvergessen and @Xenopathic to be potential reviewers

nickvergessen
nickvergessen reviewed Apr 22, 2016
View reviewed changes
core/Command/App/CheckCode.php
@@ -170,6 +170,9 @@ protected function execute(InputInterface $input, OutputInterface $output) {
$errors = array_merge($errors, $infoErrors);
}

$infoErrors = $this->analyseUpdateFile($appId, $output);
$errors = array_merge($errors, $infoErrors);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a deprecated feature should not make the app fail on travis in my opinion....

So I'm against returning 101 in that case

@DeepDiver1975
Copy link
Member Author

@nickvergessen addressed - THX a lot!

@nickvergessen
Copy link
Contributor 

$ ./occ app:check-code activity
Deprecated field available: shipped => true
Deprecated file found: /home/nickv/ownCloud/master/core/appsrepos/activity/appinfo/update.php - please use repair steps
App is compliant - awesome job!

$ ./occ app:check-code systemtags_management
App is compliant - awesome job!

👍

@MorrisJobke
Copy link
Contributor

Tested and works 👍

@DeepDiver1975 DeepDiver1975 merged commit 5a82387 into master Apr 22, 2016
@DeepDiver1975 DeepDiver1975 deleted the deprecate-update.php branch April 22, 2016 18:34
@MorrisJobke MorrisJobke mentioned this pull request Apr 25, 2016
Closed
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
4 - To release comp:apps
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@DeepDiver1975 @mention-bot @nickvergessen @MorrisJobke