First steps of zip folder plugin

[DeepDiver1975]

No description provided.

[mention-bot]

By analyzing the blame information on this pull request, we identified @LukasReschke, @rullzer, @blizzz and @DeepDiver1975 to be potential reviewers

[PVince81]

Ah! What a discovery! Nice thing

[DeepDiver1975]

Bloody olf wip ...

[PVince81]

Works now:
ZIP: curl -D - -X GET -H "Accept: application/zip" http://admin:admin@localhost/owncloud/remote.php/dav/files/admin/test -o test.zip
tar: curl -D - -X GET -H "Accept: application/x-tar" http://admin:admin@localhost/owncloud/remote.php/dav/files/admin/test -o test.tar.

If no "Accept" header is given, it will auto-detect based on user-agent or default to ZIP.

Yes, I changed the behavior because depending on the given extension could conflict with an existing file stored in ownCloud.

I had to hack Sabre a bit to prevent it to send its own response so that the streamer can use the good old dirty "echo directly the output".

@DeepDiver1975 @butonic @mrow4a check it out !

TODOs:

• unit tests

[PVince81]

Note: this doesn't fully replace the download endpoints. We're still missing something like "MGET" with a list of files to download from a given folder. Maybe we can do this separately if we agree on using a custom method.

[PVince81]

before I start with the pain of writing tests I'd like to know whether the approach described above is acceptable

[PVince81]

moving to backlog until there is more interest

[PVince81]

old PR... do we still want this ? if yes, please review...

[mrow4a]

Maybe just integrate already existing plugin, which my friend implemented once https://github.com/deic-dk/files_compress and that should work @PVince81 @DeepDiver1975

[DeepDiver1975]

Maybe just integrate already existing plugin, which my friend implemented once https://github.com/deic-dk/files_compress and that should work

I dislike the code and the concept

[DeepDiver1975]

old PR... do we still want this ? if yes, please review...

let me revive this ....

[DeepDiver1975]

@PVince81 test side effect bullshit as usual or real issue ❓

[PVince81]

might be the bullshit one... I didn't rebase this PR yet on a version that doesn't have this

[PVince81]

wait... you did rebase 😢

I don't see how it could be related

[PVince81]

it's indeed the bullshit zombie fail, PR to annihilate it: #28310

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.