Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move \OC\AppFramework to PSR-4 #24200

Merged
merged 2 commits into from
Apr 22, 2016
Merged

Move \OC\AppFramework to PSR-4 #24200

merged 2 commits into from
Apr 22, 2016

Conversation

rullzer
Copy link
Contributor

@rullzer rullzer commented Apr 22, 2016

Big one ;)

  • Had to move the adding of the autoloader a bit up. Since initpaths needs it (for the 3rdparty autoloader).
  • Fixed some faulty includes (Appframework vs AppFramework).

CC: @nickvergessen @MorrisJobke @DeepDiver1975

* Also moved the autoloader setup a bit up since we need it in initpaths
@rullzer rullzer added this to the 9.1-current milestone Apr 22, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @LukasReschke and @BernhardPosselt to be potential reviewers

@MorrisJobke
Copy link
Contributor

Tested and still works 👍

@DeepDiver1975
Copy link
Member

integration tests badly falling apart 👎

@LukasReschke
Copy link
Member

09:48:23 [Fri Apr 22 09:48:23 2016] ::1:43506 [500]: /ocs/v2.php/cloud/users/user0 - Class 'OC\AppFramework\routing\RouteConfig' not found in /ssd/jenkins/workspace/ocs-api-integration-tests-ci@2/lib/public/appframework/app.php on line 98

Seems like some use statements are not adjusted? ;)

@rullzer
Copy link
Contributor Author

rullzer commented Apr 22, 2016

Will take care... But now the big question why phpstorm did not find those...

@rullzer
Copy link
Contributor Author

rullzer commented Apr 22, 2016

Ok Fixed.

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit e37b95a into master Apr 22, 2016
@DeepDiver1975 DeepDiver1975 deleted the appframework_psr4 branch April 22, 2016 15:22
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants