Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[External storage - Google Drive] skip google map files #24285

Closed
wants to merge 2 commits into from

Conversation

lanato
Copy link
Contributor

@lanato lanato commented Apr 26, 2016

Possible fix for #24253 by ignoring google map files

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @LukasReschke, @MTGap, @AdamWill and @Xenopathic to be potential reviewers

@PVince81 PVince81 added this to the 9.1-current milestone Apr 26, 2016
@PVince81
Copy link
Contributor

Thanks a lot! Now for the official stuff, you need to either pick the MIT license by stating it or sign the CLA:

"
Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/
"

Am currently busy with other stuff but I'll try and test this in the context of 9.1. 😄

@ghost
Copy link

ghost commented Apr 26, 2016

@Altyr

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@lanato
Copy link
Contributor Author

lanato commented Apr 26, 2016

This contribution is licensed under the MIT License

@ghost
Copy link

ghost commented Apr 26, 2016

@Altyr

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@PVince81
Copy link
Contributor

@Altyr don't mind the drunken bot... sorry.

@PVince81
Copy link
Contributor

Damn, second time I try to test this and bump against #24407

@PVince81
Copy link
Contributor

Tested together with the SSL fix #24630

Works fine 👍

Second review ? @Xenopathic @icewind1991

@PVince81
Copy link
Contributor

Can we merge this ? Quick one... @Xenopathic @icewind1991

@PVince81
Copy link
Contributor

@Altyr ah, it's you too ! I didn't realize it was you who made these two PRs 😄
Great stuff

@PVince81
Copy link
Contributor

Rebased, had to do it in a separate PR: #24807
Let's continue there.

@PVince81 PVince81 closed this May 24, 2016
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants