Update notifications for core and apps

[nickvergessen]

• Trigger notifications for new updates in a background job
• Parse the notifications
• Make notification user group configurable in the UI
• Automatically delete the notification when an app/core was updated => No hooks, needs to move to "on rendering"
• Add unit tests ?!

[mention-bot]

By analyzing the blame information on this pull request, we identified @BernhardPosselt, @DeepDiver1975 and @LukasReschke to be potential reviewers

[nickvergessen]

Done, ready for review

[nickvergessen]

@LukasReschke @VicDeo @rullzer @PVince81

[PVince81]

protip: $(...).toggleClass('hidden', boolValue)

[nickvergessen]

can't toggle, because then I need to catch the case when you change from stable to product and not toggle...

[nickvergessen]

same for beta, and then it's messier than now

[PVince81]

Not really, this code should behave the same as yours, but shorter:
$('#oca_updatenotification_groups em').toggleClass('hidden', !(newChannel === 'git' || newChannel === 'daily'))

Anyway, it's not a biggie.

[PVince81]

Will the notification be recreated during the next update check or is there code that makes sure the notification only appears once ? I didn't seem to find it, maybe it's a feature of the notifications app ?

[nickvergessen]

Yes, each new update will generate a new notification, but before that we delete the old notifications, in case one had them still unread.
Also the app removes the notifications, when the update has already been installed, so the other admins don't need to click the notification away

[PVince81]

if no groups were selected, disable the background job completely (or make it no-op)
In some scenarios an admin might not want to have a bkg job pinging the app store for every app regularily.

[PVince81]

Ok, maybe one can just disable the update notification app

[PVince81]

App update notification doesn't seem to work for me.
What I did:

1. Install the Notes app from Rekkyt from the app store
2. Edit apps/notes/info.xml and set the version to 2.0.0 (it was 2.0.1)
3. update oc_jobs set last_run=null;
4. run CLI cron
5. Refresh the web page

There are no new entries in oc_notifications.
If I go to the apps page, the yellow notification appears.

The core update notification works though, so the jobs does run but something might not work correctly with apps updates.

[PVince81]

Just debugged a bit, and I saw it go here: https://github.com/owncloud/core/pull/24444/files#diff-b720db44b64d429650b1fa2d2bbbc777R129 even though there is no entry in oc_notifications (was never for this app)

Ok, so I tried doing this: update oc_appconfig set configvalue="2.0.0" where configkey="notes" and appid="updatenotification";.

Now when I run cron, there's an entry in oc_notifications.

MariaDB [owncloud]> select * from oc_notifications;
+-----------------+--------------------+-------+------------+-------------+-----------+------------------+--------------------+---------+--------------------+----------------------------------------------------+---------+
| notification_id | app                | user  | timestamp  | object_type | object_id | subject          | subject_parameters | message | message_parameters | link                                               | actions |
+-----------------+--------------------+-------+------------+-------------+-----------+------------------+--------------------+---------+--------------------+----------------------------------------------------+---------+
|               3 | updatenotification | admin | 1462890969 | notes       | 2.0.1     | update_available | []                 |         | []                 | http://localhost/index.php/settings/apps#app-notes | []      |
+-----------------+--------------------+-------+------------+-------------+-----------+------------------+--------------------+---------+--------------------+----------------------------------------------------+---------+

However when I refresh the web UI, that entry just disappears and nothing appears in the UI !

[nickvergessen]

I guess because your cheat was incomplete and the installed_version in appconfig is 2.0.1?

[PVince81]

Indeed. Works now 👍

[nickvergessen]

Second review @schiesbn @ChristophWurst @rullzer

[rullzer]

👍

[PVince81]

@nickvergessen mind rebasing so we can see at least the basic DB tests pass ? Thanks (results timed out)

[nickvergessen]

I just ran them locally and they all passed, but sure can slap jenkins in a bit

[PVince81]

@nickvergessen here, use this 👢

[nickvergessen]

Done

[PVince81]

CC @carlaschroder @jospoortvliet for this enhancement

[nickvergessen]

Docs in https://github.com/owncloud/documentation/issues/2449

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.