Make chunk cache ttl configurable #24812
Conversation
This makes it less generic and only used for actual file chunking
|
Fixes #23455 |
|
Hmm, I should probably rename the value to "chunk_ttl" since the value now only applies to chunks |
Yes that would be a lot better 👍 otherwise |
|
@PVince81 wouldn't it make more sense to have some more logic for chunks? So update the mtime of all chunks (if it is more than X difference?) so... that way as long as the user resumes upload withing a certain ttl no chunks will be removed. Also makes sense from kind of an abstract point that you never want to delete chunks of a file that you are actively uploading... |
| * issues uploading very large files via the ownCloud Client as upload isn't | ||
| * completed within one day. | ||
| */ | ||
| 'cache_folder_gc_ttl' => 86400, // 60*60*24 = 1 day |
There was a problem hiding this comment.
I should probably rename the value to "chunk_ttl" since the value now only applies to chunks
|
Ok. fine by me then 👍 |
|
I think this value is too low, especially if there is nothing done like @rullzer had recommended Especially if a user shuts down his/her machine at night or is travelling or [...] ? |
|
@guruz this was always the default. Won't change it in this PR. The purpose of this PR is making it configurable. If you want a higher default value, please raise a separate ticket. |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Continuation of #23486
Please review @icewind1991 @nickvergessen @schiesbn @rullzer
CC @guruz