Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more files plugins to new DAV endpoint #26186

Merged
merged 3 commits into from
Oct 4, 2016
Merged

Conversation

PVince81
Copy link
Contributor

Description

Add plugin for share properties, comment-unread property and report plugin on the new Webdav files endpoint.

Related Issue

For #25494

Motivation and Context

To be able to retrieve all properties we had before on the old endpoint, we need these as well on the new files endpoint.

How Has This Been Tested?

  • test if favorite entries still work in the "Favorite" section (due to changes in report plugin)
  • Merge this PR with Switch the web UI to the new endpoint for logged in users #25494 and check in the web UI that:
    • set entries as favorite then go the the favorite list: all entries listed
    • create a link share, refresh the page: share indicator appears properly
    • with curl do a REPORT with oc:favorite criteria on a subdirectory on both old and new endpoint: results still appear with the correct href of the matching endpoint

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 @butonic

@PVince81 PVince81 added this to the 9.2 milestone Sep 22, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @nickvergessen and @LukasReschke to be potential reviewers

Also fix report plugin to properly retrieve the path from the
prolongated URL
@PVince81
Copy link
Contributor Author

adjusted unit tests

@DeepDiver1975
Copy link
Member

👍

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants