Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use closure to properly defer l10n initialization #27328

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 7, 2017

Description

fixes translation of web ui for ldap users. backport to 9.1 requested

Related Issue

Motivation and Context

Mixed language in the UI.

How Has This Been Tested?

locally, with ldap and german, english, spanish language mix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975, @Gadzy and @Xenopathic to be potential reviewers.

@butonic
Copy link
Member Author

butonic commented Mar 7, 2017

waiting for CI will then backport.

also, I don't know if I catched all occurrences of this. I certainly did not catch the ones in other apps ... how do we enforce them to defer initialization ... The problem is that $l is initialized in app.php ... way before the user preferences have been loaded.

I guess we need to log a warning when anything but a closure is used?

@butonic butonic changed the title use closer to properly defer l10n initialization use closure to properly defer l10n initialization Mar 7, 2017
@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 8e36c55 into master Mar 7, 2017
@DeepDiver1975 DeepDiver1975 deleted the fix-translation branch March 7, 2017 23:19
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants