Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9.1] Custom Authentication Mechanisms for WebDAV and APIs #27370

Merged
merged 2 commits into from
Mar 21, 2017

Conversation

joneug
Copy link
Contributor

@joneug joneug commented Mar 13, 2017

Description

This is a backport of #26742 to stable9. It would be great to update sabre/dav to 3.2 (as in master), too, because it would simplify the implementation of Bearer Authentication.

Related Issue

#10400

Motivation and Context

This, for example, allows the implementation of Bearer Authentication with OAuth 2.0 (see OAuth 2.0 app).

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@joneug, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @tomneedham and @DeepDiver1975 to be potential reviewers.

@PVince81
Copy link
Contributor

It would be great to update sabre/dav to 3.2

We don't update major library versions in minor releases, sorry. This is likely to cause a lot of breakage.

@PVince81
Copy link
Contributor

@DeepDiver1975 can you restart the Jenkins job ? Not sure why this specific random failure is back

@joneug
Copy link
Contributor Author

joneug commented Mar 15, 2017

We don't update major library versions in minor releases, sorry. This is likely to cause a lot of breakage.

I see.

@DeepDiver1975 can you restart the Jenkins job ? Not sure why this specific random failure is back

That would be great.

@joneug
Copy link
Contributor Author

joneug commented Mar 17, 2017

@PVince81 Are we ready to merge?

@joneug
Copy link
Contributor Author

joneug commented Mar 20, 2017

Or is there something to change?

@PVince81
Copy link
Contributor

@DeepDiver1975 @phisch please review

@DeepDiver1975 DeepDiver1975 added this to the 9.1.5 milestone Mar 21, 2017
@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 04cfdda into owncloud:stable9.1 Mar 21, 2017
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants