Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for tag with emojis #27406

Merged
merged 2 commits into from
May 4, 2017
Merged

Add tests for tag with emojis #27406

merged 2 commits into from
May 4, 2017

Conversation

davitol
Copy link
Contributor

@davitol davitol commented Mar 17, 2017

This PR adds tests for tagging with emojis and removes a duplicated test

@davitol davitol added this to the 10.0 milestone Mar 17, 2017
@davitol davitol self-assigned this Mar 17, 2017
@mention-bot
Copy link

@davitol, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81 to be a potential reviewer.

PVince81
PVince81 reviewed Mar 20, 2017
View reviewed changes
tests/integration/features/tags.feature Outdated
Scenario: Renaming a normal tag to an emoji as regular user should work
Given user "user0" exists
Given "admin" creates a "normal" tag with name "MySuperAwesomeTagName"
When "user0" edits the tag with name "MySuperAwesomeTagName" and sets its name to "😀""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra double quote ?

@PVince81
Copy link
Contributor

You were unlucky and one of the dockers didn't start.

Please rebase to rerun the test and use the opportunity to squash as well.

@PVince81
Copy link
Contributor 

14:41:18 --- Failed scenarios:
14:41:18 
14:41:18     /var/lib/jenkins/workspace/owncloud-core_core_PR-27406-RUIIGTWZWJ62JGNTDRIPG3WZQKHDORITZHNHNCK5YMCEK37OZ7WQ/tests/integration/features/tags.feature:53

@SergioBertolinSG
Copy link
Contributor

This requires the same improvement as #27332

@PVince81 PVince81 modified the milestones: 10.0.1, 10.0 Apr 26, 2017
@davitol
Copy link
Contributor Author

davitol commented May 4, 2017

👍

@davitol davitol merged commit 749bd8b into master May 4, 2017
@davitol davitol deleted the EmojiTag branch May 4, 2017 12:56
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 left review comments

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

Assignees

@davitol davitol

Labels
3 - To Review dev:integration-tests
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@davitol @mention-bot @PVince81 @SergioBertolinSG