[stable9.1] Enable GDrive retries and backoff for rate limit

[PVince81]

Makes it possible to still get successful calls after delayed retries
when hitting the API limits.

To test:

1. Mount GDrive as "/gdrive"
2. Setup local sync client
3. Create a lot of files in the local "gdrive" folder: for I in $(seq 1 200); do echo "test" > file$I.txt; done
4. Start sync client

Before the fix: lots of API rate limit errors.
After the fix: lots more successes and rare API limit errors

Please review @jvillafanez @butonic @davicente

Backports:

• master
• stable9 ? (if the correct lib version is used there)

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MTGap, @AdamWill, @icewind1991 and @Xenopathic to be potential reviewers.

[davitol]

Applying the PR the logs (403) User Rate Limit Exceeded\" are not longer shown, but the sync speed is too slow, at least in my configuration:

Tested with oC 2.2.4 Desktop Client

[PVince81]

@davitol hmm, that's possibly because for each PHP request it will redo the backoff dance: fire a lot of requests, get the errors, then slow down, try again, slow down, etc. Instead of settling on a request speed and reuse it for every request.

That's unfortunately a limitation of the library.

[PVince81]

I guess slow sync is still an improvement over lots of errors ?

It sounds like we'll eventually need to write our own library... or reimplement exponential backoff in a way that works more efficiently 😦

[davitol]

IMO it is better this approach than the one with errors, but It should not be the definitive solution.

[PVince81]

master: 776f031

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.