Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI goes back to old DAV endpoint #28914

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Web UI goes back to old DAV endpoint #28914

merged 1 commit into from
Sep 6, 2017

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 5, 2017

Description

Workaround for #28779 as the new DAV endpoint still has issues.

Related Issue

Ref #28779

Motivation and Context

This is to prevent the regression in the next release.
We need to continue working on a fix for new DAV: #28853.

How Has This Been Tested?

Test steps in #28779.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SergioBertolinSG
Copy link
Contributor

👎 I cannot login:

jquery.ocdialog.js:235 Uncaught ReferenceError: jQuery is not defined
    at jquery.ocdialog.js:235
(anonymous) @ jquery.ocdialog.js:235
js.js?v=26f3c112a58914556ec451ee9aacaa4b:1666 Uncaught ReferenceError: $ is not defined
    at js.js?v=26f3c112a58914556ec451ee9aacaa4b:1666
(anonymous) @ js.js?v=26f3c112a58914556ec451ee9aacaa4b:1666
l10n.js?v=26f3c112a58914556ec451ee9aacaa4b:222 Uncaught ReferenceError: _ is not defined
    at l10n.js?v=26f3c112a58914556ec451ee9aacaa4b:222
(anonymous) @ l10n.js?v=26f3c112a58914556ec451ee9aacaa4b:222
l10n.js?v=26f3c112a58914556ec451ee9aacaa4b:70 Uncaught ReferenceError: _ is not defined
    at Object.register (l10n.js?v=26f3c112a58914556ec451ee9aacaa4b:70)
    at es.js:1
register @ l10n.js?v=26f3c112a58914556ec451ee9aacaa4b:70
(anonymous) @ es.js:1
octemplate.js:104 Uncaught ReferenceError: jQuery is not defined
    at octemplate.js:104
(anonymous) @ octemplate.js:104
search.js:389 Uncaught ReferenceError: OCA is not defined
    at search.js:389
    at search.js:390
(anonymous) @ search.js:389
(anonymous) @ search.js:390
oc-requesttoken.js:1 Uncaught ReferenceError: $ is not defined
    at oc-requesttoken.js:1
(anonymous) @ oc-requesttoken.js:1
apps.js:111 Uncaught ReferenceError: jQuery is not defined
    at apps.js:111
(anonymous) @ apps.js:111
oc-backbone.js:12 Uncaught ReferenceError: _ is not defined
    at oc-backbone.js:12
(anonymous) @ oc-backbone.js:12
placeholder.js:151 Uncaught ReferenceError: jQuery is not defined
    at placeholder.js:151
(anonymous) @ placeholder.js:151
jquery.avatar.js:132 Uncaught ReferenceError: jQuery is not defined
    at jquery.avatar.js:132
(anonymous) @ jquery.avatar.js:132
backgroundjobs.js:23 Uncaught ReferenceError: $ is not defined
    at backgroundjobs.js:23
(anonymous) @ backgroundjobs.js:23
shareconfigmodel.js:21 Uncaught TypeError: Cannot read property 'Model' of undefined
    at shareconfigmodel.js:21
    at shareconfigmodel.js:97
(anonymous) @ shareconfigmodel.js:21
(anonymous) @ shareconfigmodel.js:97
sharemodel.js:18 Uncaught TypeError: Cannot read property 'Model' of undefined
    at sharemodel.js:18
    at sharemodel.js:120
(anonymous) @ sharemodel.js:18
(anonymous) @ sharemodel.js:120
sharescollection.js:18 Uncaught TypeError: Cannot read property 'Collection' of undefined
    at sharescollection.js:18
    at sharescollection.js:31
(anonymous) @ sharescollection.js:18
(anonymous) @ sharescollection.js:31
shareitemmodel.js:79 Uncaught TypeError: Cannot read property 'Model' of undefined
    at shareitemmodel.js:79
    at shareitemmodel.js:736
(anonymous) @ shareitemmodel.js:79
(anonymous) @ shareitemmodel.js:736
sharedialogresharerinfoview.js:35 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialogresharerinfoview.js:35
    at sharedialogresharerinfoview.js:124
(anonymous) @ sharedialogresharerinfoview.js:35
(anonymous) @ sharedialogresharerinfoview.js:124
sharedialoglinklistview.js:66 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialoglinklistview.js:66
    at sharedialoglinklistview.js:310
(anonymous) @ sharedialoglinklistview.js:66
(anonymous) @ sharedialoglinklistview.js:310
sharedialoglinkshareview.js:17 Uncaught ReferenceError: t is not defined
    at sharedialoglinkshareview.js:17
    at sharedialoglinkshareview.js:375
(anonymous) @ sharedialoglinkshareview.js:17
(anonymous) @ sharedialoglinkshareview.js:375
sharedialogmailview.js:33 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialogmailview.js:33
    at sharedialogmailview.js:172
(anonymous) @ sharedialogmailview.js:33
(anonymous) @ sharedialogmailview.js:172
sharedialoglinksocialview.js:44 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialoglinksocialview.js:44
    at sharedialoglinksocialview.js:114
(anonymous) @ sharedialoglinksocialview.js:44
(anonymous) @ sharedialoglinksocialview.js:114
sharedialogexpirationview.js:40 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialogexpirationview.js:40
    at sharedialogexpirationview.js:188
(anonymous) @ sharedialogexpirationview.js:40
(anonymous) @ sharedialogexpirationview.js:188
sharedialogshareelistview.js:79 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialogshareelistview.js:79
    at sharedialogshareelistview.js:296
(anonymous) @ sharedialogshareelistview.js:79
(anonymous) @ sharedialogshareelistview.js:296
sharedialogview.js:57 Uncaught TypeError: Cannot read property 'View' of undefined
    at sharedialogview.js:57
    at sharedialogview.js:474
(anonymous) @ sharedialogview.js:57
(anonymous) @ sharedialogview.js:474
share.js:6 Uncaught ReferenceError: _ is not defined
    at share.js:6
(anonymous) @ share.js:6
visitortimezone.js:2 Uncaught ReferenceError: $ is not defined
    at visitortimezone.js:2
(anonymous) @ visitortimezone.js:2
lostpassword.js:2 Uncaught ReferenceError: t is not defined
    at lostpassword.js:2
(anonymous) @ lostpassword.js:2
login.js:13 Uncaught ReferenceError: _ is not defined
    at login.js:13
(anonymous) @ login.js:13
browser-update.js:9 Uncaught ReferenceError: $ is not defined
    at browser-update.js:9

@jvillafanez
Copy link
Member

Too big breakage for such a small change. I think something broke during the deployment, but it's likely unrelated to this change.

@SergioBertolinSG
Copy link
Contributor

Yes, it was a problem with the npm registry.
Works 👍

@PVince81 PVince81 merged commit 9d6cf21 into master Sep 6, 2017
@PVince81 PVince81 deleted the webui-back-to-olddav branch September 6, 2017 13:21
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 6, 2017

stable10: #28924

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants