-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirm password after new password #30981
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30981 +/- ##
============================================
- Coverage 64.84% 64.84% -0.01%
Complexity 18324 18324
============================================
Files 1198 1198
Lines 69580 69579 -1
Branches 1283 1283
============================================
- Hits 45120 45118 -2
- Misses 24086 24087 +1
Partials 374 374
Continue to review full report at Codecov.
|
@pmaier1 see above, looks like this would be useful |
for consistency, might need to add a "confirm second password" to the personal page |
@sharidas please rebase. if this is finished we could move forward as it's a nice addition |
a6aa745
to
5901972
Compare
This will need some webUILogin acceptance test changes - the UI workflow changes and the acceptance test will need to input the new password twice now. |
|
13c6cd4
to
f0d9cae
Compare
507d410
to
fdada49
Compare
The confirm password would help to validate if the password entered is same as new password entered. Signed-off-by: Sujith H <[email protected]>
fdada49
to
c5fa36a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
we can ignore codecov as this is covered by acceptance tests |
@sharidas please backport |
Backport |
The confirm password would help to validate
if the password entered is same as new
password entered.
Signed-off-by: Sujith H [email protected]
Description
The confirm password text box would help users to validate the new password. If there is any mismatch between 2 passwords then no reset action should take place.
Related Issue
#29901
Motivation and Context
The confirm password text box would help users to validate the new password. If there is any mismatch between 2 passwords then no reset action should take place.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: