Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting apiSharing feature file into different files #31422

Merged
merged 1 commit into from
May 11, 2018

Conversation

paurakhsharma
Copy link
Member

@paurakhsharma paurakhsharma commented May 11, 2018

Description

The apiSharing feature file is now split into other small manageable feature files

Related Issue

#31531

Motivation and Context

To make adding more tests easier

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in file structure

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable first split of the existing sharing scenarios. Now the plan is to look at each of these feature files and reorganize/expand the test scenarios to achieve a sensible level of API acceptance test coverage of each feature.
During that process, some feature files may be split into more pieces. Because actually there will be quite a lot of scenarios for this stuff, taking into account the various permission combinations, user/group/public... share types and all the things a share receiver can and cannot do with each combination.

@phil-davis
Copy link
Contributor

This will be "interesting" to backport. First compare the "old" sharing feature file in master and stable10 - if they are the same then it is easy. If they are different, then we need to look at why, and then sort out what of the differences go where.

@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #31422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31422   +/-   ##
=========================================
  Coverage     62.64%   62.64%           
  Complexity    18255    18255           
=========================================
  Files          1145     1145           
  Lines         68481    68481           
  Branches       1234     1234           
=========================================
  Hits          42898    42898           
  Misses        25222    25222           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.84% <ø> (ø) 18255 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bd14b...87af0c0. Read the comment docs.

@phil-davis phil-davis merged commit 07b0e06 into owncloud:master May 11, 2018
@paurakhsharma
Copy link
Member Author

paurakhsharma commented May 11, 2018

Backport on #31423

individual-it added a commit to owncloud/files_primary_s3 that referenced this pull request May 19, 2018
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants