Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split webdav feature #32365

Merged
merged 5 commits into from
Aug 17, 2018
Merged

Split webdav feature #32365

merged 5 commits into from
Aug 17, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 17, 2018

Description

  1. Split the existing scenarios into smaller feature files, without changing anything.
  2. Remove duplicate scenarios (in the big webdav-related.feature there were some duplicated scenarios that nobody noticed)
  3. Add a scenario for deleting a file (that feature was empty!)
  4. Add a scenarios for deleting a folder (that feature was empty!)
  5. Move the common "creating user0" step into the background wherever possible

Related Issue

#32366

Motivation and Context

The apiWebDAV acceptance tests are mostly in one huge feature file.
In order to understand what is tested, it needs to be in smaller feature files for the individual upload, download, move, copy, delete... features that make up "webDAV".

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Acceptance tests added

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #32365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32365   +/-   ##
=========================================
  Coverage     64.03%   64.03%           
  Complexity    18579    18579           
=========================================
  Files          1171     1171           
  Lines         69876    69876           
  Branches       1267     1267           
=========================================
  Hits          44747    44747           
  Misses        24759    24759           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.31% <ø> (ø) 18579 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ebad0...7f80ef5. Read the comment docs.

@phil-davis phil-davis merged commit 5936799 into master Aug 17, 2018
@phil-davis phil-davis deleted the split-webdav-feature branch August 17, 2018 08:25
@phil-davis
Copy link
Contributor Author

phil-davis commented Aug 17, 2018

Backport stable10 #32367

@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants