Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occ test cli provisioning disable app #33084

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

paurakhsharma
Copy link
Member

@paurakhsharma paurakhsharma commented Oct 9, 2018

Description

This PR adds more tests for cliProvisioning disableApp using occ commands.

Related issue: #33054

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Scenario: Admin tries to disable an app which is not enabled
Given the app "comments" has been disabled
When the administrator disables the app "comments" using the occ command
Then the command should have been successful
Copy link
Member Author

@paurakhsharma paurakhsharma Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81, Here the occ command gives success status code. Actually, it makes sense but just want to make sure if it is an expected behavior.

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #33084 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33084   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18724    18724           
=========================================
  Files          1185     1185           
  Lines         70460    70460           
  Branches       1270     1270           
=========================================
  Hits          45198    45198           
  Misses        24892    24892           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18724 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9541c7a...464b7eb. Read the comment docs.

@paurakhsharma paurakhsharma merged commit 7b156ed into master Oct 9, 2018
@paurakhsharma paurakhsharma deleted the occTest-cliProvisioning-disableApp branch October 9, 2018 04:40
@lock lock bot locked as resolved and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants