Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for getting app info #33114

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

paurakhsharma
Copy link
Member

@paurakhsharma paurakhsharma commented Oct 10, 2018

Description

This PR adds more tests for cliProvisioning getAppInfo using occ commands.

Related issue: #33054

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -268,6 +268,19 @@ public function theAdministratorEnablesTheAppUsingTheOccCommand($appName) {
);
}

/**
* @When administrator gets the app info of the app :appName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/When administrator/When the administrator/

@paurakhsharma paurakhsharma force-pushed the occTest-cliProvisioning-getAppInfo branch from 7778e85 to fda140f Compare October 10, 2018 04:38
@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #33114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33114   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18725    18725           
=========================================
  Files          1185     1185           
  Lines         70463    70463           
  Branches       1270     1270           
=========================================
  Hits          45201    45201           
  Misses        24892    24892           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18725 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f5c75...fda140f. Read the comment docs.

@paurakhsharma paurakhsharma merged commit dbc2f7a into master Oct 10, 2018
@paurakhsharma paurakhsharma deleted the occTest-cliProvisioning-getAppInfo branch October 10, 2018 05:05
@phil-davis
Copy link
Contributor

Backport stable10 #33115

This was referenced Nov 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants